<html>
<head><meta charset="utf-8"><title>new contributor approval · t-cargo · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/index.html">t-cargo</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html">new contributor approval</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="246346625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246346625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yerkebulan Tulibergenov <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246346625">(Jul 17 2021 at 22:00)</a>:</h4>
<p>Hello. I just made my first cargo PR <a href="https://github.com/rust-lang/cargo/pull/9702">https://github.com/rust-lang/cargo/pull/9702</a><br>
Can someone please kick off CI so it would run tests? Thanks.</p>



<a name="246348108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246348108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246348108">(Jul 17 2021 at 22:45)</a>:</h4>
<p>I will when I get home</p>



<a name="246350116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246350116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246350116">(Jul 17 2021 at 23:43)</a>:</h4>
<p>Looks like someone beat me to it. Welcome to to project!</p>



<a name="246350778"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246350778" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yerkebulan Tulibergenov <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246350778">(Jul 18 2021 at 00:02)</a>:</h4>
<p>Thank you! <span class="user-mention" data-user-id="120179">@Eh2406</span> Do you have time to help me understand the desired behavior for <a href="https://github.com/rust-lang/cargo/issues/9518">https://github.com/rust-lang/cargo/issues/9518</a> ? Do we want this error to happen only in dev dependencies or not? My current PR is breaking <code>build::self_dependency</code> test which has <code>[dependencies.test] path = "."</code> and I don't know if that is ok or not.</p>



<a name="246351036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246351036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yerkebulan Tulibergenov <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246351036">(Jul 18 2021 at 00:10)</a>:</h4>
<p>Here are the CI failures after my first commit: <a href="https://github.com/rust-lang/cargo/pull/9702/checks?check_run_id=3094933575">https://github.com/rust-lang/cargo/pull/9702/checks?check_run_id=3094933575</a></p>



<a name="246351947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246351947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246351947">(Jul 18 2021 at 00:40)</a>:</h4>
<p>I think those are all errors anyway.  Changing how it errors seems fine to me. But we should probably update the tests to demonstrate more complicated cyclic dependencies.<br>
<span class="user-mention" data-user-id="120518">@Eric Huss</span> what do you think?</p>



<a name="246352287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246352287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yerkebulan Tulibergenov <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246352287">(Jul 18 2021 at 00:50)</a>:</h4>
<p>Thanks for feedback. I pushed several commits and would like to restart the CI, if possible. All tests pass for me locally on MacOS.</p>



<a name="246352581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246352581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246352581">(Jul 18 2021 at 01:00)</a>:</h4>
<p>I thought we had this set so once you got approval it stayed approved. But I gave it a approval again.</p>



<a name="246371789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246371789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246371789">(Jul 18 2021 at 11:01)</a>:</h4>
<p>I think with the current setting it requires approval until someone has gotten a commit in.</p>



<a name="246371791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246371791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246371791">(Jul 18 2021 at 11:01)</a>:</h4>
<p>Until then, you still count as a new contributor, and every CI run requires approval.</p>



<a name="246371803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246371803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246371803">(Jul 18 2021 at 11:02)</a>:</h4>
<p>There's been discussion of improving that setting for the rust repositories.</p>



<a name="246465617"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246465617" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246465617">(Jul 19 2021 at 14:57)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> Was this option enabled org-wide?</p>
<p><a href="/user_uploads/4715/Obg6e-lAL7Kse_43x_J90CTs/image.png">image.png</a> </p>
<div class="message_inline_image"><a href="/user_uploads/4715/Obg6e-lAL7Kse_43x_J90CTs/image.png" title="image.png"><img src="/user_uploads/4715/Obg6e-lAL7Kse_43x_J90CTs/image.png"></a></div><p>We are still getting new PRs from new contributors that have accounts that are years old that are requiring approval. (<a href="https://github.com/rust-lang/cargo/pull/9702">https://github.com/rust-lang/cargo/pull/9702</a>)</p>



<a name="246465806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246465806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246465806">(Jul 19 2021 at 14:58)</a>:</h4>
<p>updated the org-wide setting to just new users</p>



<a name="246465853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246465853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246465853">(Jul 19 2021 at 14:58)</a>:</h4>
<p>Thanks! <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="246466496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246466496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246466496">(Jul 19 2021 at 15:01)</a>:</h4>
<p>I thought I enabled it, maybe forgot tho</p>



<a name="246466522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/246057-t-cargo/topic/new%20contributor%20approval/near/246466522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/246057-t-cargo/topic/new.20contributor.20approval.html#246466522">(Jul 19 2021 at 15:01)</a>:</h4>
<p>thanks for the ping, and thanks mark for handling it!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>